Conversation
jzunigax2
force-pushed
the
chore/error-handler
branch
from
efd9900 to
9490865
Compare
sg-gs
requested changes
Feb 3, 2026
| await expect( | ||
| callController.createCall(mockUserToken.payload), | ||
| ).rejects.toThrow(InternalServerErrorException); | ||
| ).rejects.toThrow('Unexpected error'); |
Member
There was a problem hiding this comment.
Shouldn't this be an error object, rather than a string?
src/common/http-exception-filter.ts
Outdated
| const message = | ||
| typeof res === 'object' && res !== null | ||
| ? res | ||
| : { statusCode: status, message: res }; |
Member
There was a problem hiding this comment.
You can and should return the requestId here also. Eventually, we can show that on the client apps to show it to the user and even report it to Sentry, to see what happened.
jzunigax2
force-pushed
the
chore/error-handler
branch
from
619bcf2 to
cb1cffd
Compare
sg-gs
approved these changes
Feb 3, 2026
…pectation for error handling
jzunigax2
force-pushed
the
chore/error-handler
branch
from
cb1cffd to
ce44434
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Global HTTP exception filter for the meet-server, based on the existing implementation in drive-server.
Why
Error handling was scattered across individual controllers with inconsistent logging and try/catch blocks. A centralized filter standardizes error responses and logging while removing boilerplate from controllers.
How